> On Apr 10, 2022, at 11:56 PM, Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote: > > On Sun, Apr 10, 2022 at 01:34:50AM +0000, Song Liu wrote: >> OTOH, it is probably beneficial for the modules to use something >> similar to bpf_prog_pack, i.e., put text from multiple modules to a >> single huge page. Of course, this requires non-trivial work in both >> mm code and module code. >> >> Given that 1) modules cannot use huge pages yet, and 2) module may >> use differently (with sharing), I think adding module_alloc_large() >> doesn't add much value at the moment. So we can just keep this logic >> in BPF for now. >> >> Does this make sense? > > I'm not intending to say modules should use the new helper. But I'd much > prefer to keep all the MODULES_VADDR related bits self-contained in the > modules code and not splatter it over random other subsystems. Got it. Will add that in v2. Thanks, Song
