On Sat, Apr 09, 2022 at 05:34:52PM +0800, Miaohe Lin wrote: > The MADV_FREE pages check in folio_check_dirty_writeback is a bit hard to > follow. Add a comment to make the code clear. > > Suggested-by: Huang, Ying <ying.huang@xxxxxxxxx> > Signed-off-by: Miaohe Lin <linmiaohe@xxxxxxxxxx> > --- > mm/vmscan.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/mm/vmscan.c b/mm/vmscan.c > index c77d5052f230..4a76be47bed1 100644 > --- a/mm/vmscan.c > +++ b/mm/vmscan.c > @@ -1436,6 +1436,9 @@ static void folio_check_dirty_writeback(struct folio *folio, > /* > * Anonymous pages are not handled by flushers and must be written > * from reclaim context. Do not stall reclaim based on them While you touch this please add a period at the end of the above sentence. Otherwise looks good: Reviewed-by: Christoph Hellwig <hch@xxxxxx>