On Fri, Apr 08, 2022 at 04:57:41AM +0000, Yosry Ahmed wrote: > Currently, cg_write() returns 0 on success and -1 on failure. Modify it > to return the errno of write() syscall when write() fails. > > Signed-off-by: Yosry Ahmed <yosryahmed@xxxxxxxxxx> > --- > tools/testing/selftests/cgroup/cgroup_util.c | 32 +++++++++++--------- > 1 file changed, 17 insertions(+), 15 deletions(-) > > diff --git a/tools/testing/selftests/cgroup/cgroup_util.c b/tools/testing/selftests/cgroup/cgroup_util.c > index dbaa7aabbb4a..3b6bb09985fa 100644 > --- a/tools/testing/selftests/cgroup/cgroup_util.c > +++ b/tools/testing/selftests/cgroup/cgroup_util.c > @@ -38,23 +38,23 @@ static ssize_t read_text(const char *path, char *buf, size_t max_len) > return len; > } > > -static ssize_t write_text(const char *path, char *buf, ssize_t len) > +/* > + * Returns: > + * success -> 0 > + * open() failure -> -1 Is there a reason why we can't return errno in this case as well? It would be more straightforward. Otherwise the change looks good to me.
