On Mon, 16 Jan 2012 09:47:15 +0100 Michal Hocko <mhocko@xxxxxxx> wrote: > On Mon 16-01-12 14:04:53, Li Zefan wrote: > > Fix this warning: > > > > CC mm/memcontrol.o > > mm/memcontrol.c: In function 'memcg_check_events': > > mm/memcontrol.c:779:22: warning: unused variable 'do_numainfo' > > This has been already posted by Kirill and I didn't like the solution > (https://lkml.org/lkml/2011/12/27/86). He then reposted with a different > version (https://lkml.org/lkml/2012/1/6/281). > The later one looks better but I still think this is not worth > complicate the code just to get rid of this warning. This? --- a/mm/memcontrol.c~a +++ a/mm/memcontrol.c @@ -776,7 +776,8 @@ static void memcg_check_events(struct me /* threshold event is triggered in finer grain than soft limit */ if (unlikely(mem_cgroup_event_ratelimit(memcg, MEM_CGROUP_TARGET_THRESH))) { - bool do_softlimit, do_numainfo; + bool do_softlimit; + bool do_numainfo __maybe_unused; do_softlimit = mem_cgroup_event_ratelimit(memcg, MEM_CGROUP_TARGET_SOFTLIMIT); _ -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>