Re: [PATCH] mm: migrate: use thp_order instead of HPAGE_PMD_ORDER for new page allocation.

[Zi Yan <ziy@xxxxxxxxxx>]

On 4 Apr 2022, at 14:28, Andrew Morton wrote:

> On Mon,  4 Apr 2022 12:53:25 -0400 Zi Yan <zi.yan@xxxxxxxx> wrote:
>
>> From: Zi Yan <ziy@xxxxxxxxxx>
>>
>> With folios support, it is possible to have other than HPAGE_PMD_ORDER
>> THPs, in the form of folios, in the system. Use thp_order() to correctly
>> determine the source page order during migration.
>
> Changelog doesn't describe the end user visible effects of the bug.
> And it really should, because
>
>> Link: https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flore.kernel.org%2Flinux-mm%2F20220404132908.GA785673%40u2004%2F&amp;data=04%7C01%7Cziy%40nvidia.com%7Cbf27ebf19d8a49a9b4b008da1668dc09%7C43083d15727340c1b7db39efd9ccc17a%7C0%7C0%7C637846936880192108%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&amp;sdata=pgvzV3wv6icqkMaWY2koB9X4VqlPMaSHeB8r7%2Fv1938%3D&amp;reserved=0
>
> it fixes a kernel crash!

Thank you for adding the information.

--
Best Regards,
Yan, Zi

Attachment: signature.asc
Description: OpenPGP digital signature