Re: [PATCH v2 2/2] mm: wrap __find_buddy_pfn() with a necessary buddy page validation.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Zi Yan <ziy@xxxxxxxxxx>
Subject: Re: [PATCH v2 2/2] mm: wrap __find_buddy_pfn() with a necessary buddy page validation.
From: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>
Date: Fri, 1 Apr 2022 12:01:07 -0700
Cc: Linux-MM <linux-mm@xxxxxxxxx>, Steven Rostedt <rostedt@xxxxxxxxxxx>, David Hildenbrand <david@xxxxxxxxxx>, Vlastimil Babka <vbabka@xxxxxxx>, Mel Gorman <mgorman@xxxxxxxxxxxxxxxxxxx>, Mike Rapoport <rppt@xxxxxxxxxx>, Oscar Salvador <osalvador@xxxxxxx>, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>, Linux Kernel Mailing List <linux-kernel@xxxxxxxxxxxxxxx>
In-reply-to: <ADC113C0-F731-4835-AE3E-87C2302877B5@nvidia.com>
References: <20220401181109.1477354-1-zi.yan@sent.com> <20220401181109.1477354-2-zi.yan@sent.com> <CAHk-=wifQimj2d6npq-wCi5onYPjzQg4vyO4tFcPJJZr268cRw@mail.gmail.com> <ADC113C0-F731-4835-AE3E-87C2302877B5@nvidia.com>

On Fri, Apr 1, 2022 at 11:56 AM Zi Yan <ziy@xxxxxxxxxx> wrote:
>
> How about the patch below? If it looks good, I will send v3.

I can't see anything worrisome, but by now I've looked at several
versions and who knows what I'm missing.

Making it inline and allowing a NULL 'buddy_pfn' pointer for the cases
that don't care might be an option, but I don't think it matters
hugely.

                   Linus

Follow-Ups:
- Re: [PATCH v2 2/2] mm: wrap __find_buddy_pfn() with a necessary buddy page validation.
  - From: Zi Yan

References:
- [PATCH v2 1/2] mm: page_alloc: simplify pageblock migratetype check in __free_one_page().
  - From: Zi Yan
- [PATCH v2 2/2] mm: wrap __find_buddy_pfn() with a necessary buddy page validation.
  - From: Zi Yan
- Re: [PATCH v2 2/2] mm: wrap __find_buddy_pfn() with a necessary buddy page validation.
  - From: Linus Torvalds
- Re: [PATCH v2 2/2] mm: wrap __find_buddy_pfn() with a necessary buddy page validation.
  - From: Zi Yan

Prev by Date: Re: [PATCH v2 2/2] mm: wrap __find_buddy_pfn() with a necessary buddy page validation.
Next by Date: Re: [PATCH v1 mmotm] mm/mprotect: try avoiding write faults for exclusive anonynmous pages when changing protection
Previous by thread: Re: [PATCH v2 2/2] mm: wrap __find_buddy_pfn() with a necessary buddy page validation.
Next by thread: Re: [PATCH v2 2/2] mm: wrap __find_buddy_pfn() with a necessary buddy page validation.
Index(es):
- Date
- Thread

[Index of Archives] [Linux ARM Kernel] [Linux ARM] [Linux Omap] [Fedora ARM] [IETF Annouce] [Bugtraq] [Linux OMAP] [Linux MIPS] [eCos] [Asterisk Internet PBX] [Linux API]