> On Mar 30, 2022, at 4:54 PM, Thomas Gleixner <tglx@xxxxxxxxxxxxx> wrote: > > On Wed, Mar 30 2022 at 15:56, Song Liu wrote: >> As HAVE_ARCH_HUGE_VMALLOC is not ready for X86_64, enable >> HAVE_ARCH_HUGE_VMALLOC_FLAG to allow bpf_prog_pack to allocate huge >> pages. > > Despite HAVE_ARCH_HUGE_VMALLOC being not ready for X86_64 enable it > nevertheless? These are two different flags: HAVE_ARCH_HUGE_VMALLOC allows vmalloc to try to allocate huge pages for size >= PMD_SIZE, unless it is disabled with nohugeiomap or VM_NO_HUGE_VMAP. HAVE_ARCH_HUGE_VMALLOC_FLAG allows vmalloc to try to allocate huge pages for size >= PMD_SIZE, only when the user specifies VM_TRY_HUGE_VMAP. Recommendations for better naming will be highly appreciated.. Song > > I assume you wanted to say something like this: > > The shortcomings of huge vmalloc allocations have been fixed in the > memory management core code, so reenable HAVE_ARCH_HUGE_VMALLOC. > > Thanks, > > tglx
