On Tue, Mar 29, 2022 at 08:43:23AM +0800, Huang, Ying wrote:
[...]
>>>> --- a/mm/migrate.c
>>>> +++ b/mm/migrate.c
>>>> @@ -2046,7 +2046,7 @@ static int numamigrate_isolate_page(pg_data_t *pgdat, struct page *page)
>>>> if (!(sysctl_numa_balancing_mode & NUMA_BALANCING_MEMORY_TIERING))
>>>> return 0;
>>>> for (z = pgdat->nr_zones - 1; z >= 0; z--) {
>>>> - if (populated_zone(pgdat->node_zones + z))
>>>> + if (managed_zone(pgdat->node_zones + z))
>>>
>>>This looks good to me! Thanks! It seems that we can replace
>>>populated_zone() in migrate_balanced_pgdat() too. Right?
>>>
>>
>> Yes, you are right. I didn't spot this.
>>
>> While this patch comes from the clue of wakeup_kswapd(), I am not sure it is
>> nice to put it in this patch together.
>>
>> Which way you prefer to include this: merge the change into this one, or a
>> separate one?
>
>Either is OK for me.
>
After reading the code, I am willing to do a little simplification. Does this
look good to you?
