On Mon, 28 Mar 2022 19:29:30 +0800 Xiaomeng Tong <xiam0nd.tong@xxxxxxxxx> wrote: > Move these two lines into the damon_for_each_region loop, it is always > for testing the last region. And also avoid to use a list iterator 'r' > outside the loop which is considered harmful[1]. > > [1]: https://lkml.org/lkml/2022/2/17/1032 Let's have one empty line here[1]. [1] https://www.kernel.org/doc/html/v4.17/process/submitting-patches.html#the-canonical-patch-format > Signed-off-by: Xiaomeng Tong <xiam0nd.tong@xxxxxxxxx> Other than the above trivial nit, Reviewed-by: SeongJae Park <sj@xxxxxxxxxx> Thanks, SJ > --- > mm/damon/vaddr-test.h | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/mm/damon/vaddr-test.h b/mm/damon/vaddr-test.h > index 6a1b9272ea12..98b7a9f54b35 100644 > --- a/mm/damon/vaddr-test.h > +++ b/mm/damon/vaddr-test.h > @@ -281,14 +281,16 @@ static void damon_test_split_evenly_succ(struct kunit *test, > KUNIT_EXPECT_EQ(test, damon_nr_regions(t), nr_pieces); > > damon_for_each_region(r, t) { > - if (i == nr_pieces - 1) > + if (i == nr_pieces - 1) { > + KUNIT_EXPECT_EQ(test, > + r->ar.start, start + i * expected_width); > + KUNIT_EXPECT_EQ(test, r->ar.end, end); > break; > + } > KUNIT_EXPECT_EQ(test, > r->ar.start, start + i++ * expected_width); > KUNIT_EXPECT_EQ(test, r->ar.end, start + i * expected_width); > } > - KUNIT_EXPECT_EQ(test, r->ar.start, start + i * expected_width); > - KUNIT_EXPECT_EQ(test, r->ar.end, end); > damon_free_target(t); > } > > -- > 2.17.1
