Re: [linux-next:master 2075/14215] drivers/net/dsa/realtek/realtek-smi.c:496:34: warning: unused variable 'realtek_smi_of_match'

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello test robot,

Thanks for your mail.

On Wed, Mar 23, 2022 at 12:48:28PM +0800, kernel test robot wrote:
> Hi Luiz,
> 
> First bad commit (maybe != root cause):
> 
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
> head:   f8833a2b23562be2dae91775127c8014c44d8566
> commit: 765c39a4fafe6f7ea0d370aa5f30c811579cf8eb [2075/14215] net: dsa: realtek: convert subdrivers into modules
> config: s390-randconfig-r005-20220323 (https://download.01.org/0day-ci/archive/20220323/202203231233.Xx73Y40o-lkp@xxxxxxxxx/config)

Looking at this config...

| # CONFIG_OF is not set

I think this is the problem. I guess something like this should do the
trick:

diff --git a/drivers/net/dsa/realtek/Kconfig b/drivers/net/dsa/realtek/Kconfig
index cd1aa95b7bf0..5ff11dcc512f 100644
--- a/drivers/net/dsa/realtek/Kconfig
+++ b/drivers/net/dsa/realtek/Kconfig
@@ -12,6 +12,7 @@ menuconfig NET_DSA_REALTEK
 config NET_DSA_REALTEK_SMI
        tristate "Realtek SMI connected switch driver"
        depends on NET_DSA_REALTEK
+       depends on OF
        default y
        help
          Select to enable support for registering switches connected

Ditto for realtek-mdio. We are using OF in both drivers.

I'll send a patch.

Kind regards,
Alvin

> >> drivers/net/dsa/realtek/realtek-smi.c:496:34: warning: unused variable 'realtek_smi_of_match' [-Wunused-const-variable]
>    static const struct of_device_id realtek_smi_of_match[] = {
>                                     ^
>    13 warnings generated.
> 
> 
> vim +/realtek_smi_of_match +496 drivers/net/dsa/realtek/realtek-smi.c
> 
> 0650bf52b31ff35 drivers/net/dsa/realtek-smi-core.c    Vladimir Oltean           2021-09-17  495  
> d8652956cf37c5c drivers/net/dsa/realtek-smi.c         Linus Walleij             2018-07-14 @496  static const struct of_device_id realtek_smi_of_match[] = {
> 765c39a4fafe6f7 drivers/net/dsa/realtek/realtek-smi.c Luiz Angelo Daros de Luca 2022-01-28  497  #if IS_ENABLED(CONFIG_NET_DSA_REALTEK_RTL8366RB)
> d8652956cf37c5c drivers/net/dsa/realtek-smi.c         Linus Walleij             2018-07-14  498  	{
> d8652956cf37c5c drivers/net/dsa/realtek-smi.c         Linus Walleij             2018-07-14  499  		.compatible = "realtek,rtl8366rb",
> d8652956cf37c5c drivers/net/dsa/realtek-smi.c         Linus Walleij             2018-07-14  500  		.data = &rtl8366rb_variant,
> d8652956cf37c5c drivers/net/dsa/realtek-smi.c         Linus Walleij             2018-07-14  501  	},
> 765c39a4fafe6f7 drivers/net/dsa/realtek/realtek-smi.c Luiz Angelo Daros de Luca 2022-01-28  502  #endif
> d8652956cf37c5c drivers/net/dsa/realtek-smi.c         Linus Walleij             2018-07-14  503  	{
> d8652956cf37c5c drivers/net/dsa/realtek-smi.c         Linus Walleij             2018-07-14  504  		/* FIXME: add support for RTL8366S and more */
> d8652956cf37c5c drivers/net/dsa/realtek-smi.c         Linus Walleij             2018-07-14  505  		.compatible = "realtek,rtl8366s",
> d8652956cf37c5c drivers/net/dsa/realtek-smi.c         Linus Walleij             2018-07-14  506  		.data = NULL,
> d8652956cf37c5c drivers/net/dsa/realtek-smi.c         Linus Walleij             2018-07-14  507  	},
> 765c39a4fafe6f7 drivers/net/dsa/realtek/realtek-smi.c Luiz Angelo Daros de Luca 2022-01-28  508  #if IS_ENABLED(CONFIG_NET_DSA_REALTEK_RTL8365MB)
> 4af2950c50c8634 drivers/net/dsa/realtek-smi-core.c    Alvin Šipraga             2021-10-18  509  	{
> 4af2950c50c8634 drivers/net/dsa/realtek-smi-core.c    Alvin Šipraga             2021-10-18  510  		.compatible = "realtek,rtl8365mb",
> 4af2950c50c8634 drivers/net/dsa/realtek-smi-core.c    Alvin Šipraga             2021-10-18  511  		.data = &rtl8365mb_variant,
> 4af2950c50c8634 drivers/net/dsa/realtek-smi-core.c    Alvin Šipraga             2021-10-18  512  	},
> 765c39a4fafe6f7 drivers/net/dsa/realtek/realtek-smi.c Luiz Angelo Daros de Luca 2022-01-28  513  #endif
> d8652956cf37c5c drivers/net/dsa/realtek-smi.c         Linus Walleij             2018-07-14  514  	{ /* sentinel */ },
> d8652956cf37c5c drivers/net/dsa/realtek-smi.c         Linus Walleij             2018-07-14  515  };
> d8652956cf37c5c drivers/net/dsa/realtek-smi.c         Linus Walleij             2018-07-14  516  MODULE_DEVICE_TABLE(of, realtek_smi_of_match);
> d8652956cf37c5c drivers/net/dsa/realtek-smi.c         Linus Walleij             2018-07-14  517  
> 
> :::::: The code at line 496 was first introduced by commit
> :::::: d8652956cf37c5caa8c19e0b99ce5ca235c6d5de net: dsa: realtek-smi: Add Realtek SMI driver
> 
> :::::: TO: Linus Walleij <linus.walleij@xxxxxxxxxx>
> :::::: CC: David S. Miller <davem@xxxxxxxxxxxxx>
> 
> -- 
> 0-DAY CI Kernel Test Service
> https://01.org/lkp
>




[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux