On Wed, Mar 16, 2022 at 04:18:30PM +0800, Miaohe Lin wrote: > On 2022/3/16 2:19, Yang Shi wrote: > > On Tue, Mar 15, 2022 at 7:19 AM Miaohe Lin <linmiaohe@xxxxxxxxxx> wrote: ... > >> > >> > >> Many thanks for comment. > >> I assume that Naoya's patch "mm/hwpoison: set PageHWPoison after taking page lock > >> in memory_failure_hugetlb()" would set the PageHWPoison after the above check. > >> So I think the below operation is not needed as PageHWPoison is not set yet. > >> Does this makes sense for you? > > > > I'm wondering if it might be better and helpful for review to squash > > this patch with Naoya's patch together? It seems we always missed the > > other part when reviewing the patches. > > > > Sounds like a good idea. This would make the reviewer's life easier. I'm fine if > this patch is squashed into Naoya's patch altogether. But we might have to consult > the opinion from Naoya. I'm fine with the squashing, so I'll send v4. Thanks, Naoya Horiguchi
