Update the list KUnit test to include a test for the new list_traverse() macro. This adds a new 'head' member to the list_test_struct to use as a list head, using the list_traverse_head macro. Signed-off-by: David Gow <davidgow@xxxxxxxxxx> --- If, as seems likely, we're going to introduce new list traversal macros, it'd be nice to update the linked list KUnit tests in lib/list-test.c to test them. :-) This patch works against the proposed list_traverse() macro posted here: https://lore.kernel.org/all/CAHk-=wiacQM76xec=Hr7cLchVZ8Mo9VDHmXRJzJ_EX4sOsApEA@xxxxxxxxxxxxxx/ Feel free to use and/or adapt it if this or a similar macro is introduced. Cheers, -- David --- lib/list-test.c | 24 ++++++++++++++++++++++++ 1 file changed, 24 insertions(+) diff --git a/lib/list-test.c b/lib/list-test.c index ee09505df16f..7fa2622ff9c7 100644 --- a/lib/list-test.c +++ b/lib/list-test.c @@ -12,6 +12,7 @@ struct list_test_struct { int data; struct list_head list; + list_traversal_head(struct list_test_struct, head, list); }; static void list_test_list_init(struct kunit *test) @@ -656,6 +657,28 @@ static void list_test_list_for_each_prev_safe(struct kunit *test) KUNIT_EXPECT_TRUE(test, list_empty(&list)); } +static void list_test_list_traverse(struct kunit *test) +{ + struct list_test_struct entries[5], head; + int i = 0; + + INIT_LIST_HEAD(&head.head); + + for (i = 0; i < 5; ++i) { + entries[i].data = i; + list_add_tail(&entries[i].list, &head.head); + } + + i = 0; + + list_traverse(cur, &head.head, list) { + KUNIT_EXPECT_EQ(test, cur->data, i); + i++; + } + + KUNIT_EXPECT_EQ(test, i, 5); +} + static void list_test_list_for_each_entry(struct kunit *test) { struct list_test_struct entries[5], *cur; @@ -733,6 +756,7 @@ static struct kunit_case list_test_cases[] = { KUNIT_CASE(list_test_list_for_each_prev), KUNIT_CASE(list_test_list_for_each_safe), KUNIT_CASE(list_test_list_for_each_prev_safe), + KUNIT_CASE(list_test_list_traverse), KUNIT_CASE(list_test_list_for_each_entry), KUNIT_CASE(list_test_list_for_each_entry_reverse), {}, -- 2.35.1.723.g4982287a31-goog