On Thu, 2022-03-10 at 11:26 -0500, Steven Rostedt wrote: > On Thu, 10 Mar 2022 10:08:18 -0600 > Tom Zanussi <zanussi@xxxxxxxxxx> wrote: > > > This patch is for the last_cmd_set() in trace_events_synth.c, yours > > is > > for trace_events_hist.c, which also has last_cmd_set(). > > Ug, name confusion :-p > > > > > The one in trace_events_synth.c is much simpler, so it seemed to me > > that strcpy() would be ok there. > > If you are only copying the string, why not just use kstrdup()? Good point, how about this?