On Tue, 17 Jan 2012 16:16:20 +0100 Michal Hocko <mhocko@xxxxxxx> wrote: > On Fri 13-01-12 17:32:27, KAMEZAWA Hiroyuki wrote: > > > > From 788aebf15f3fa37940e0745cab72547e20683bf2 Mon Sep 17 00:00:00 2001 > > From: KAMEZAWA Hiroyuki <kamezawa.hiroyu@xxxxxxxxxxxxxx> > > Date: Thu, 12 Jan 2012 16:08:33 +0900 > > Subject: [PATCH 1/7] memcg: remove unnecessary check in mem_cgroup_update_page_stat() > > > > commit 10ea69f1182b removes move_lock_page_cgroup() in thp-split path. > > So, this PageTransHuge() check is unnecessary, too. > > I do not see commit like that in the tree. I guess you meant > memcg: make mem_cgroup_split_huge_fixup() more efficient which is not > merged yet, right? > This commit in the linux-next. > commit e94c8a9cbce1aee4af9e1285802785481b7f93c5 > Author: KAMEZAWA Hiroyuki <kamezawa.hiroyu@xxxxxxxxxxxxxx> > Date: Thu Jan 12 17:18:20 2012 -0800 > > memcg: make mem_cgroup_split_huge_fixup() more efficient > > > > > Note: > > - considering when mem_cgroup_update_page_stat() is called, > > there will be no race between split_huge_page() and update_page_stat(). > > All required locks are held in higher level. > > We should never have THP page in this path in the first place. So why > not changing this to VM_BUG_ON(PageTransHuge). > Ying Han considers to support mlock stat. Thanks, -Kame -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>