On Thu, Mar 10, 2022 at 1:15 AM David Rientjes <rientjes@xxxxxxxxxx> wrote: > > On Wed, 9 Mar 2022, Matthew Wilcox wrote: > > > On Wed, Mar 09, 2022 at 10:50:52PM +0800, sxwjean@xxxxxx wrote: > > > From: Xiongwei Song <sxwjean@xxxxxxxxx> > > > > > > The parameter @s is useless for alloc_slab_page(), let's delete it. > > > > Perhaps we could add a little more information here. > > > > It was added in 2014 by 5dfb41750992 ("sl[au]b: charge slabs to kmemcg > > explicitly"). The need for it was removed in 2020 by 1f3147b49d75 > > ("mm: slub: call account_slab_page() after slab page initialization"). > > > > Reviewed-by: Matthew Wilcox (Oracle) <willy@xxxxxxxxxxxxx> > > > > Acked-by: David Rientjes <rientjes@xxxxxxxxxx> Thank you!