The error code is missing in this code scenario, add the error code '-ENOMEM' to the return value 'err'. Eliminate the follow smatch warning: mm/damon/sysfs.c:1647 damon_sysfs_attrs_add_dirs() warn: missing error code 'err'. Reported-by: Abaci Robot <abaci@xxxxxxxxxxxxxxxxx> Signed-off-by: Jiapeng Chong <jiapeng.chong@xxxxxxxxxxxxxxxxx> --- mm/damon/sysfs.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/mm/damon/sysfs.c b/mm/damon/sysfs.c index 32a9d21c0db5..0eca71163924 100644 --- a/mm/damon/sysfs.c +++ b/mm/damon/sysfs.c @@ -1643,8 +1643,10 @@ static int damon_sysfs_attrs_add_dirs(struct damon_sysfs_attrs *attrs) attrs->intervals = intervals; nr_regions_range = damon_sysfs_ul_range_alloc(10, 1000); - if (!nr_regions_range) + if (!nr_regions_range) { + err = -ENOMEM; goto put_intervals_out; + } err = kobject_init_and_add(&nr_regions_range->kobj, &damon_sysfs_ul_range_ktype, &attrs->kobj, -- 2.20.1.7.g153144c