On Sat, Feb 19, 2022 at 10:26 AM Miaohe Lin <linmiaohe@xxxxxxxxxx> wrote:
>
> Use put_z3fold_header() to pair with get_z3fold_header. Also fix the wrong
> comments. Minor readability improvement.
>
> Signed-off-by: Miaohe Lin <linmiaohe@xxxxxxxxxx>
Reviewed-by: Vitaly Wool <vitaly.wool@xxxxxxxxxxxx>
> ---
> mm/z3fold.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/mm/z3fold.c b/mm/z3fold.c
> index 87689f50f709..eb89271aea83 100644
> --- a/mm/z3fold.c
> +++ b/mm/z3fold.c
> @@ -1187,9 +1187,9 @@ static int z3fold_alloc(struct z3fold_pool *pool, size_t size, gfp_t gfp,
> * @handle: handle associated with the allocation returned by z3fold_alloc()
> *
> * In the case that the z3fold page in which the allocation resides is under
> - * reclaim, as indicated by the PG_reclaim flag being set, this function
> - * only sets the first|last_chunks to 0. The page is actually freed
> - * once both buddies are evicted (see z3fold_reclaim_page() below).
> + * reclaim, as indicated by the PAGE_CLAIMED flag being set, this function
> + * only sets the first|middle|last_chunks to 0. The page is actually freed
> + * once all buddies are evicted (see z3fold_reclaim_page() below).
> */
> static void z3fold_free(struct z3fold_pool *pool, unsigned long handle)
> {
> @@ -1247,7 +1247,7 @@ static void z3fold_free(struct z3fold_pool *pool, unsigned long handle)
> }
> if (page_claimed) {
> /* the page has not been claimed by us */
> - z3fold_page_unlock(zhdr);
> + put_z3fold_header(zhdr);
> return;
> }
> if (test_and_set_bit(NEEDS_COMPACTING, &page->private)) {
> --
> 2.23.0
>
