RE: [PATCH] selftests, x86: fix how check_cc.sh is being invoked

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



From: Guillaume Tucker
> Sent: 25 February 2022 18:50
...
> > -if "$CC" -o /dev/null "$TESTPROG" -O0 "$@" 2>/dev/null; then
> > +if $CC -o /dev/null "$TESTPROG" -O0 "$@" 2>/dev/null; then
> >      echo 1
> >  else
> >      echo 0
> 
> I see the change in check_cc.sh is already covered by Usama's patch:
> 
>   selftests/x86: Add validity check and allow field splitting
> 
> -if "$CC" -o /dev/null "$TESTPROG" -O0 "$@" 2>/dev/null; then
> +if [ -n "$CC" ] && $CC -o /dev/null "$TESTPROG" -O0 "$@" 2>/dev/null; then

Or:
	if ${CC:-false} -o /dev/null ....
There's always one more way...

	David

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)




[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux