On Wed, Feb 23, 2022 at 03:20:42PM +0000, SeongJae Park wrote: > +static struct kobj_attribute damon_sysfs_ul_range_min_attr = > + __ATTR(min, 0600, damon_sysfs_ul_range_min_show, > + damon_sysfs_ul_range_min_store); > + > +static struct kobj_attribute damon_sysfs_ul_range_max_attr = > + __ATTR(max, 0600, damon_sysfs_ul_range_max_show, > + damon_sysfs_ul_range_max_store); Can you use __ATTR_RW_MODE() instead here and elsewhere? thanks, greg k-h