Hello Jonghyeon, On Fri, 18 Feb 2022 19:26:08 +0900 Jonghyeon Kim <tome01@xxxxxxxxxx> wrote: > > Current DAMON_RECALIM is not compatible with the NUMA memory system. To > proactively reclaim memory, DAMON_RECLAIM kernel thread(kdamond) has to wake up > before kswapd does reclaim memory. However, the current watermark for proactive > reclamation is based on entire system free memory. So, though the one memory > node is fully used, kdamond is not waked up. > > These patches clarify watermarks of DAMOS and enable monitoring per NUMA node > proactive reclamation on DAMON_RECLAIM. The high level concept of this patchset looks good to me. Nevertheless, maybe there is some rooms for improvement. I left some comments on patches. Thanks, SJ > > Jonghyeon Kim (3): > mm/damon: Rebase damos watermarks for NUMA systems > mm/damon/core: Add damon_start_one() > mm/damon/reclaim: Add per NUMA node proactive reclamation by > DAMON_RECLAIM. > > include/linux/damon.h | 3 + > mm/damon/core.c | 39 +++++++++-- > mm/damon/reclaim.c | 147 ++++++++++++++++++++++++++++++------------ > 3 files changed, 140 insertions(+), 49 deletions(-) > > -- > 2.17.1
