On Mon, Feb 21, 2022 at 04:45:31PM +0100, David Hildenbrand wrote: > Let's make it clearer at which places we actually add and remove memory > blocks -- streamlining the terminology -- and highlight which memory > block start out online and which start out as offline. > > * rename add_memory_block -> add_boot_memory_block > * rename init_memory_block -> add_memory_block > * rename unregister_memory -> remove_memory_block > * rename register_memory -> __add_memory_block > * add add_hotplug_memory_block > * mark add_boot_memory_block with __init (suggested by Oscar) > > __add_memory_block() is a pure helper for add_memory_block(), remove > the somewhat obvious comment. > > Cc: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> > Cc: "Rafael J. Wysocki" <rafael@xxxxxxxxxx> > Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> > Cc: Michal Hocko <mhocko@xxxxxxxx> > Cc: Oscar Salvador <osalvador@xxxxxxx> > Signed-off-by: David Hildenbrand <david@xxxxxxxxxx> Thanks for doing this, it makes the code much more clear. Reviewed-by: Oscar Salvador <osalvador@xxxxxxx> > --- > > Based on v5.17-rc5 and: > [PATCH v2 0/2] drivers/base/memory: determine and store zone for > single-zone memory blocks [1] Maybe just my thing, but I also had to pull in [1] in order to apply this error-free. [1] https://patchwork.kernel.org/project/linux-mm/patch/20220128144540.153902-1-david@xxxxxxxxxx/ -- Oscar Salvador SUSE Labs
