On Wed, 11 Jan 2012, Ying Han wrote:
> We have the nr_mlock stat both in meminfo as well as vmstat system wide, this
> patch adds the mlock field into per-memcg memory stat. The stat itself enhances
> the metrics exported by memcg, especially is used together with "uneivctable"
> lru stat.
>
> --- a/include/linux/page_cgroup.h
> +++ b/include/linux/page_cgroup.h
> @@ -10,6 +10,7 @@ enum {
> /* flags for mem_cgroup and file and I/O status */
> PCG_MOVE_LOCK, /* For race between move_account v.s. following bits */
> PCG_FILE_MAPPED, /* page is accounted as "mapped" */
> + PCG_MLOCK, /* page is accounted as "mlock" */
> /* No lock in page_cgroup */
> PCG_ACCT_LRU, /* page has been accounted for (under lru_lock) */
> __NR_PCG_FLAGS,
Is this really necessary? KAMEZAWA-san is engaged in trying to reduce
the number of PageCgroup flags, and I expect that in due course we shall
want to merge them in with Page flags, so adding more is unwelcome.
I'd have thought that with memcg_ hooks in the right places,
a separate flag would not be necessary?
Hugh
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxx. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>