On 2022/2/19 9:24, Peter Collingbourne wrote: > The function kasan_global_oob was renamed to kasan_global_oob_right, > but the comments referring to it were not updated. Do so. > > Link: https://linux-review.googlesource.com/id/I20faa90126937bbee77d9d44709556c3dd4b40be > Signed-off-by: Peter Collingbourne <pcc@xxxxxxxxxx> > Fixes: e5f4728767d2 ("kasan: test: add globals left-out-of-bounds test") This Fixes tag is unneeded. Except the above nit, this patch looks good to me. Thanks. Reviewed-by: Miaohe Lin <linmiaohe@xxxxxxxxxx> > --- > lib/test_kasan.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/lib/test_kasan.c b/lib/test_kasan.c > index 26a5c9007653..a8dfda9b9630 100644 > --- a/lib/test_kasan.c > +++ b/lib/test_kasan.c > @@ -780,7 +780,7 @@ static void ksize_uaf(struct kunit *test) > static void kasan_stack_oob(struct kunit *test) > { > char stack_array[10]; > - /* See comment in kasan_global_oob. */ > + /* See comment in kasan_global_oob_right. */ > char *volatile array = stack_array; > char *p = &array[ARRAY_SIZE(stack_array) + OOB_TAG_OFF]; > > @@ -793,7 +793,7 @@ static void kasan_alloca_oob_left(struct kunit *test) > { > volatile int i = 10; > char alloca_array[i]; > - /* See comment in kasan_global_oob. */ > + /* See comment in kasan_global_oob_right. */ > char *volatile array = alloca_array; > char *p = array - 1; > > @@ -808,7 +808,7 @@ static void kasan_alloca_oob_right(struct kunit *test) > { > volatile int i = 10; > char alloca_array[i]; > - /* See comment in kasan_global_oob. */ > + /* See comment in kasan_global_oob_right. */ > char *volatile array = alloca_array; > char *p = array + i; > >
