On Tue, Feb 15, 2022 at 7:02 PM Shiyang Ruan <ruansy.fnst@xxxxxxxxxxx> wrote: > > > > 在 2022/2/16 9:34, Dan Williams 写道: > > On Thu, Jan 27, 2022 at 4:41 AM Shiyang Ruan <ruansy.fnst@xxxxxxxxxxx> wrote: > >> > >> The current dax_lock_page() locks dax entry by obtaining mapping and > >> index in page. To support 1-to-N RMAP in NVDIMM, we need a new function > >> to lock a specific dax entry > > > > I do not see a call to dax_lock_entry() in this function, what keeps > > this lookup valid after xas_unlock_irq()? > > I am not sure if I understood your advice correctly: You said > dax_lock_entry() is not necessary in v9[1]. So, I deleted it. > > [1]: > https://lore.kernel.org/linux-xfs/CAPcyv4jVDfpHb1DCW+NLXH2YBgLghCVy8o6wrc02CXx4g-Bv7Q@xxxxxxxxxxxxxx/ I also said, "if the filesystem can make those guarantees" it was not clear whether this helper is being called back from an FS context that guarantees those associations or not. As far as I can see there is nothing that protects that association. Apologies for the confusion, I was misunderstanding where the protection was being enforced in this case.
