Re: [PATCH 08/10] mm: Turn deactivate_file_page() into deactivate_file_folio()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: "Matthew Wilcox (Oracle)" <willy@xxxxxxxxxxxxx>
Subject: Re: [PATCH 08/10] mm: Turn deactivate_file_page() into deactivate_file_folio()
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Mon, 14 Feb 2022 23:25:47 -0800
Cc: linux-fsdevel@xxxxxxxxxxxxxxx, linux-mm@xxxxxxxxx
In-reply-to: <20220214200017.3150590-9-willy@infradead.org>
References: <20220214200017.3150590-1-willy@infradead.org> <20220214200017.3150590-9-willy@infradead.org>

On Mon, Feb 14, 2022 at 08:00:15PM +0000, Matthew Wilcox (Oracle) wrote:
> This function has one caller which already has a reference to the
> page, so we don't need to use get_page_unless_zero().  Also move the
> prototype to mm/internal.h.

Looks good:

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

References:
- [PATCH 00/10] Various fixes around invalidate_page()
  - From: Matthew Wilcox (Oracle)
- [PATCH 08/10] mm: Turn deactivate_file_page() into deactivate_file_folio()
  - From: Matthew Wilcox (Oracle)

Prev by Date: Re: [PATCH 07/10] mm/truncate: Convert __invalidate_mapping_pages() to use a folio
Next by Date: Re: [PATCH 09/10] mm/truncate: Combine invalidate_mapping_pagevec() and __invalidate_mapping_pages()
Previous by thread: [PATCH 08/10] mm: Turn deactivate_file_page() into deactivate_file_folio()
Next by thread: Re: [PATCH 08/10] mm: Turn deactivate_file_page() into deactivate_file_folio()
Index(es):
- Date
- Thread

[Index of Archives] [Linux ARM Kernel] [Linux ARM] [Linux Omap] [Fedora ARM] [IETF Annouce] [Bugtraq] [Linux OMAP] [Linux MIPS] [eCos] [Asterisk Internet PBX] [Linux API]

Powered by Linux