On Sun 08-01-12 16:01:17, Michal Marek wrote: > Dne 27.12.2011 14:57, Michal Hocko napsal(a): > > Anyway, I am wondering why unused-but-set-variable is disabled while > > unused-variable is enabled. > > unused-but-set-variable was disabled, because it was a new warning in > gcc 4.6 and produced too much noise relatively to its severity. A make > W=1 build of x86_64_defconfig gives: > $ grep -c 'Wunused-but-set-variable' log > 77 > $ grep -c 'Wunused-variable' log > 0 > > More exotic configuration will probably result in a couple of unused > variable warnings, but that IMO no reason to disable them globally. OK. > > Shouldn't we just disable it as well rather > > than workaround this in the code? The warning is just pure noise in this > > case. > > If it's noise in a particular case, there is always the option to add > > CFLAGS_memcontrol.o := $(call cc-disable-warning, unused-variable) I would like to prevent from local cflags hacks. Moreover the code will go away so I guess it doesn't make much sense to play tricks here. > > to the respective Makefile. > > Michal Thanks -- Michal Hocko SUSE Labs SUSE LINUX s.r.o. Lihovarska 1060/12 190 00 Praha 9 Czech Republic -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>