Re: [PATCH 6/8] mm: don't include <linux/memremap.h> in <linux/mm.h>

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




Am 2022-02-09 um 12:48 schrieb Christoph Hellwig:
On Mon, Feb 07, 2022 at 04:19:29PM -0500, Felix Kuehling wrote:
Am 2022-02-07 um 01:32 schrieb Christoph Hellwig:
Move the check for the actual pgmap types that need the free at refcount
one behavior into the out of line helper, and thus avoid the need to
pull memremap.h into mm.h.

Signed-off-by: Christoph Hellwig <hch@xxxxxx>
The amdkfd part looks good to me.

It looks like this patch is not based on Alex Sierra's coherent memory
series. He added two new helpers is_device_coherent_page and
is_dev_private_or_coherent_page that would need to be moved along with
is_device_private_page and is_pci_p2pdma_page.
FYI, here is a branch that contains a rebase of the coherent memory
related patches on top of this series:

http://git.infradead.org/users/hch/misc.git/shortlog/refs/heads/pgmap-refcount

I don't have a good way to test this, but I'll at least let the build bot
finish before sending it out (probably tomorrow).

Thank you for taking care of this rebase! Alex tested it on one of our coherent memory systems and it passed our tests.

I see you also included these rebased patches in your latest 27-patch series. I'll try to review the changes in more detail over the weekend.

Regards,
  Felix







[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux