Hi Hugh, On Wed, Feb 9, 2022 at 4:38 PM Hugh Dickins <hughd@xxxxxxxxxx> wrote: > The thing is, SeongJae's patch makes me wonder, why did it not need a > !CONFIG_MMU definition for need_mlock_page_drain() too? That's because > mm/swap.c's call to it is under an #ifdef CONFIG_SMP, and I imagine that > CONFIG_MMU=n usually goes along with (but does not necessarily imply?) > CONFIG_SMP=n. It'll be safer to add a need_mlock_page_drain() stub too. RISC-V K210 is SMP without MMU. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds