On Sun, 6 Feb 2022, Matthew Wilcox wrote: > On Sun, Feb 06, 2022 at 01:27:41PM -0800, Hugh Dickins wrote: > > Here it is based on 5.17-rc2, applies also to -rc3, almost cleanly to > > mmotm 2022-02-03-21-58 (needs two easy fixups in mm/huge_memory.c); but > > likely to conflict (I hope not fundamentally) with several concurrent > > large patchsets. > > Most of this patchset hasn't arrived here yet, but I would be > _delighted_ to rebase the folio conversion on top of this. What > convoluted code it is! I am so glad you've cleaned this up; I was > dreading doing the rest of the mlock file. That's a very generous offer: thank you. I'd been looking at it the other way round, afraid that it would be getting in your way: but now think you're right, that the cleanup there will help your work. I had found mm/mlock.c unexpectedly difficult to deal with when doing shmem huge pages, and IIRC Kirill had the same experience. Hugh