On Sun, Feb 06, 2022 at 08:13:11PM +0200, Mike Rapoport wrote: > On Fri, Feb 04, 2022 at 07:58:18PM +0000, Matthew Wilcox (Oracle) wrote: > > I need to use this function in common code, so define it for hexagon. > > > > Signed-off-by: Matthew Wilcox (Oracle) <willy@xxxxxxxxxxxxx> > > --- > > arch/hexagon/include/asm/pgtable.h | 3 ++- > > Why hexagon out of all architectures? > What about m68k, nios2, nds32 etc? Presumably they don't support CONFIG_TRANSPARENT_HUGEPAGE. This code isn't compiled when THP are disabled; at least I haven't had a buildbot complaint for any other architectures. > > +#define pmd_pfn(pmd) (pmd_val(pmd) >> PAGE_SHIFT) > > I'd put it in include/linux/pgtable.h inside #ifndef pmd_pfn That's completely upside down. pmd_pfn() should be defined by each architecture (because generic code can't know anything about the format of PMDs); if anything pmd_page() should be defined in linux/pgtable.h in terms of pmd_pfn. I'm not signing up to do that work as part of this series. That seems like a distraction.
