On Sun, Jan 30, 2022 at 09:17:50PM -0800, John Hubbard wrote: > Regardless of any FOLL_* flags, get_user_pages() and its variants should > handle PFN-only entries by stopping early, if the caller expected > **pages to be filled in. > > This makes for a more reliable API, as compared to the previous approach > of skipping over such entries (and thus leaving them silently > unwritten). > > Cc: Peter Xu <peterx@xxxxxxxxxx> > Suggested-by: Jason Gunthorpe <jgg@xxxxxxxx> > Signed-off-by: John Hubbard <jhubbard@xxxxxxxxxx> > --- > mm/gup.c | 12 +++++++----- > 1 file changed, 7 insertions(+), 5 deletions(-) I still think it should be squashed into the previous path, but otherwise Reviewed-by: Jason Gunthorpe <jgg@xxxxxxxxxx> Jason
