Hi Mike, On Sun, 2022-01-30 at 18:10 +0200, Mike Rapoport wrote: > On Fri, Jan 28, 2022 at 12:21:59PM +0100, Karolina Drobnik wrote: > > On Thu, 2022-01-27 at 14:09 +0000, Matthew Wilcox wrote: > > > On Thu, Jan 27, 2022 at 02:21:25PM +0100, Karolina Drobnik wrote: > > > > Add a dummy io.h header. > > > > > > Rather begs the question of what memblock.c needs from > > > linux/io.h. > > > > > > Wouldn't it be better to: > > > > > > +++ b/mm/memblock.c > > > @@ -18,7 +18,6 @@ > > > #include <linux/memblock.h> > > > > > > #include <asm/sections.h> > > > -#include <linux/io.h> > > > > > > #include "internal.h" > > > > > > > That was something I considered in the very beginning, but didn't > > have > > a chance to verify it works for all architectures. I can take a > > look > > after I'm finished with other v2 changes. > > > > > (allmodconfig on x86-64 builds fine with this; I have not done an > > > extended sweep of other arches / build options). > > I did a sweep for defconfigs for all arches and all were fine. Thanks for doing the sweep, it's very helpful. > Karolina, please send the formal patch. Let's see how kbuild bot > reacts. OK, will send something later today. All the best, Karolina
