Re: [PATCH v2 1/3] lib/vsprintf: Avoid redundant work with 0 size

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: David Rientjes <rientjes@xxxxxxxxxx>
Subject: Re: [PATCH v2 1/3] lib/vsprintf: Avoid redundant work with 0 size
From: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
Date: Mon, 31 Jan 2022 12:25:09 +0200
Cc: Waiman Long <longman@xxxxxxxxxx>, Johannes Weiner <hannes@xxxxxxxxxxx>, Michal Hocko <mhocko@xxxxxxxxxx>, Vladimir Davydov <vdavydov.dev@xxxxxxxxx>, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>, Petr Mladek <pmladek@xxxxxxxx>, Steven Rostedt <rostedt@xxxxxxxxxxx>, Sergey Senozhatsky <senozhatsky@xxxxxxxxxxxx>, Rasmus Villemoes <linux@xxxxxxxxxxxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, cgroups@xxxxxxxxxxxxxxx, linux-mm@xxxxxxxxx, Ira Weiny <ira.weiny@xxxxxxxxx>, Rafael Aquini <aquini@xxxxxxxxxx>
In-reply-to: <d99b3c4b-7b6e-529-6e4b-b91b65c92d81@google.com>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
References: <20220129205315.478628-1-longman@redhat.com> <20220129205315.478628-2-longman@redhat.com> <d99b3c4b-7b6e-529-6e4b-b91b65c92d81@google.com>

On Sun, Jan 30, 2022 at 12:49:37PM -0800, David Rientjes wrote:
> On Sat, 29 Jan 2022, Waiman Long wrote:
> 
> > For *scnprintf(), vsnprintf() is always called even if the input size is
> > 0. That is a waste of time, so just return 0 in this case.

Why do you think it's not legit?

-- 
With Best Regards,
Andy Shevchenko

Follow-Ups:
- Re: [PATCH v2 1/3] lib/vsprintf: Avoid redundant work with 0 size
  - From: Andy Shevchenko

References:
- [PATCH v2 0/3] mm/page_owner: Extend page_owner to show memcg information
  - From: Waiman Long
- [PATCH v2 1/3] lib/vsprintf: Avoid redundant work with 0 size
  - From: Waiman Long
- Re: [PATCH v2 1/3] lib/vsprintf: Avoid redundant work with 0 size
  - From: David Rientjes

Prev by Date: Re: [PATCH] mm/memory_hotplug: build zonelist for managed_zone
Next by Date: Re: [PATCH v2 1/3] lib/vsprintf: Avoid redundant work with 0 size
Previous by thread: Re: [PATCH v2 1/3] lib/vsprintf: Avoid redundant work with 0 size
Next by thread: Re: [PATCH v2 1/3] lib/vsprintf: Avoid redundant work with 0 size
Index(es):
- Date
- Thread

[Index of Archives] [Linux ARM Kernel] [Linux ARM] [Linux Omap] [Fedora ARM] [IETF Annouce] [Bugtraq] [Linux OMAP] [Linux MIPS] [eCos] [Asterisk Internet PBX] [Linux API]