On Fri, 23 Dec 2011 21:00:41 +0800 Hillf Danton <dhillf@xxxxxxxxx> wrote: > Page mapcount should be updated only if we are sure that the page ends > up in the page table otherwise we would leak if we couldn't COW due to > reservations or if idx is out of bounds. It would be much nicer if we could run vma_needs_reservation() before even looking up or allocating the page. And afaict the interface is set up to do that: you run vma_needs_reservation() before allocating the page and then vma_commit_reservation() afterwards. But hugetlb_no_page() and hugetlb_fault() appear to have forgotten to run vma_commit_reservation() altogether. Why isn't this as busted as it appears to be? -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>