On Fri, Jan 28, 2022 at 12:25:55PM +0100, Karolina Drobnik wrote: > On Thu, 2022-01-27 at 14:06 +0000, Matthew Wilcox wrote: > > On Thu, Jan 27, 2022 at 02:21:28PM +0100, Karolina Drobnik wrote: > > > +# Memblock simulator requires AddressSanitizer (libasan) and > > > liburcu libraries > > > > Stale comment? You don't seem to actually use liburcu. > > I'm using uatomic_inc and uatomic_dec in tools/lib/slab.c. But, you're > right, memblock simulator doesn't use liburcu per se but uses code that > requires it. I wasn't sure where and how to communicate it, so I added > this comment here. I thought the comment was stale because you don't link against liburcu. Maybe you can use uatomic_inc() without adding -lurcu to the link step.