Re: [PATCH 5/5] memcg: remove redundant returns

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat 31-12-11 23:33:24, Hugh Dickins wrote:
> Remove redundant returns from ends of functions, and one blank line.
> 
> Signed-off-by: Hugh Dickins <hughd@xxxxxxxxxx>

Acked-by: Michal Hocko <mhocko@xxxxxxx>

> ---
>  mm/memcontrol.c |    5 -----
>  1 file changed, 5 deletions(-)
> 
> --- mmotm.orig/mm/memcontrol.c	2011-12-30 21:29:03.695349263 -0800
> +++ mmotm/mm/memcontrol.c	2011-12-30 21:29:37.611350065 -0800
> @@ -1362,7 +1362,6 @@ void mem_cgroup_print_oom_info(struct me
>  	if (!memcg || !p)
>  		return;
>  
> -
>  	rcu_read_lock();
>  
>  	mem_cgrp = memcg->css.cgroup;
> @@ -1897,7 +1896,6 @@ out:
>  	if (unlikely(need_unlock))
>  		move_unlock_page_cgroup(pc, &flags);
>  	rcu_read_unlock();
> -	return;
>  }
>  EXPORT_SYMBOL(mem_cgroup_update_page_stat);
>  
> @@ -2691,7 +2689,6 @@ __mem_cgroup_commit_charge_lrucare(struc
>  		SetPageLRU(page);
>  	}
>  	spin_unlock_irqrestore(&zone->lru_lock, flags);
> -	return;
>  }
>  
>  int mem_cgroup_cache_charge(struct page *page, struct mm_struct *mm,
> @@ -2881,7 +2878,6 @@ direct_uncharge:
>  		res_counter_uncharge(&memcg->memsw, nr_pages * PAGE_SIZE);
>  	if (unlikely(batch->memcg != memcg))
>  		memcg_oom_recover(memcg);
> -	return;
>  }
>  
>  /*
> @@ -3935,7 +3931,6 @@ static void memcg_get_hierarchical_limit
>  out:
>  	*mem_limit = min_limit;
>  	*memsw_limit = min_memsw_limit;
> -	return;
>  }
>  
>  static int mem_cgroup_reset(struct cgroup *cont, unsigned int event)

-- 
Michal Hocko
SUSE Labs
SUSE LINUX s.r.o.
Lihovarska 1060/12
190 00 Praha 9    
Czech Republic

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxx.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>


[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]