Re: [PATCH 13/23] NFS: rename nfs_direct_IO and use as ->swap_rw

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: NeilBrown <neilb@xxxxxxx>
Subject: Re: [PATCH 13/23] NFS: rename nfs_direct_IO and use as ->swap_rw
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Mon, 24 Jan 2022 00:57:34 -0800
Cc: Trond Myklebust <trond.myklebust@xxxxxxxxxxxxxxx>, Anna Schumaker <anna.schumaker@xxxxxxxxxx>, Chuck Lever <chuck.lever@xxxxxxxxxx>, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>, Mel Gorman <mgorman@xxxxxxx>, Christoph Hellwig <hch@xxxxxxxxxxxxx>, David Howells <dhowells@xxxxxxxxxx>, linux-nfs@xxxxxxxxxxxxxxx, linux-mm@xxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx
In-reply-to: <164299611281.26253.6497855219394305186.stgit@noble.brown>
References: <164299573337.26253.7538614611220034049.stgit@noble.brown> <164299611281.26253.6497855219394305186.stgit@noble.brown>

> +extern int nfs_swap_rw(struct kiocb *, struct iov_iter *);

Might be worth to drop the pointless extern while you're at it.

Otherwise looks good:

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

References:
- [PATCH 00/23 V3] Repair SWAP-over_NFS
  - From: NeilBrown
- [PATCH 13/23] NFS: rename nfs_direct_IO and use as ->swap_rw
  - From: NeilBrown

Prev by Date: Re: [PATCH 12/23] NFS: remove IS_SWAPFILE hack
Next by Date: Re: [PATCH 14/23] NFS: swap IO handling is slightly different for O_DIRECT IO
Previous by thread: [PATCH 13/23] NFS: rename nfs_direct_IO and use as ->swap_rw
Next by thread: [PATCH 14/23] NFS: swap IO handling is slightly different for O_DIRECT IO
Index(es):
- Date
- Thread

[Index of Archives] [Linux ARM Kernel] [Linux ARM] [Linux Omap] [Fedora ARM] [IETF Annouce] [Bugtraq] [Linux OMAP] [Linux MIPS] [eCos] [Asterisk Internet PBX] [Linux API]

Powered by Linux