From: Alex Shi <alexs@xxxxxxxxxx> The function could be fully replaced by lruvec_add_folio_tail, no reason to keep a duplicate one. Signed-off-by: Alex Shi <alexs@xxxxxxxxxx> Cc: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> Cc: Yu Zhao <yuzhao@xxxxxxxxxx> Cc: Alex Shi <alexs@xxxxxxxxxx> Cc: Vlastimil Babka <vbabka@xxxxxxx> Cc: Arnd Bergmann <arnd@xxxxxxxx> Cc: linux-kernel@xxxxxxxxxxxxxxx Cc: linux-mm@xxxxxxxxx --- include/linux/mm_inline.h | 6 ------ mm/swap.c | 2 +- 2 files changed, 1 insertion(+), 7 deletions(-) diff --git a/include/linux/mm_inline.h b/include/linux/mm_inline.h index 7d7abd5ff73f..4df5b39cc97b 100644 --- a/include/linux/mm_inline.h +++ b/include/linux/mm_inline.h @@ -102,12 +102,6 @@ void lruvec_add_folio_tail(struct lruvec *lruvec, struct folio *folio) list_add_tail(&folio->lru, &lruvec->lists[lru]); } -static __always_inline void add_page_to_lru_list_tail(struct page *page, - struct lruvec *lruvec) -{ - lruvec_add_folio_tail(lruvec, page_folio(page)); -} - static __always_inline void lruvec_del_folio(struct lruvec *lruvec, struct folio *folio) { diff --git a/mm/swap.c b/mm/swap.c index fb101a06dce4..23c0afb76be6 100644 --- a/mm/swap.c +++ b/mm/swap.c @@ -550,7 +550,7 @@ static void lru_deactivate_file_fn(struct page *page, struct lruvec *lruvec) * The page's writeback ends up during pagevec * We move that page into tail of inactive. */ - add_page_to_lru_list_tail(page, lruvec); + lruvec_add_folio_tail(lruvec, page_folio(page)); __count_vm_events(PGROTATED, nr_pages); } -- 2.25.1