On Thu, 29 Dec 2011, Konstantin Khlebnikov wrote:
>
> Nice patch
>
> Reviewed-by: Konstantin Khlebnikov <khlebnikov@xxxxxxxxxx>
Thanks.
> As I see, this patch is on top "memcg naturalization" patchset,
> it does not apply clearly against Linus tree.
Right, it's certainly not intended as a last-minute "fix" to 3.2,
but as a patch for mmotm and linux-next then 3.3. Linus doesn't
even have your free_hot_cold_page_list() yet.
>
> > + if (put_page_testzero(page)) {
> > + __ClearPageLRU(page);
> > + __ClearPageActive(page);
> > + del_page_from_lru_list(zone, page, lru);
> > +
> > + if (unlikely(PageCompound(page))) {
> > + spin_unlock_irq(&zone->lru_lock);
>
> There is good place for VM_BUG_ON(!PageHead(page));
Well, my inertia wanted to find a reason to disagree with you on that,
and indeed I found one! If this were a tail page, the preceding
put_page_testzero() should already have hit its
VM_BUG_ON(atomic_read(&page->_count) == 0);
(since Andrea changed the THP refcounting to respect get_page_unless_zero).
Hugh
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxx. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>