On 1/14/22, Dave Hansen <dave.hansen@xxxxxxxxx> wrote: > On 1/13/22 1:30 PM, Martin Fernandez wrote: >> +/* >> + * Update crypto capabilities in a range >> + */ >> +static u64 __init __e820__range_update_crypto(struct e820_table *table, >> + u64 start, u64 size, >> + enum e820_crypto_capabilities crypto_capable) > > This looks like an almost pure copy-and-paste of a 70-line function. > That's not the end of the world, but it does seem like a place where > refactoring is in order. > > The rest of this series looks pretty straightforward, but this part in > particular is the most worrying. > Yep, I'm not super happy with this either. I'll check it out to see what we can do. Btw e820__range_remove is quite similiar too.
