Re: [PATCH] mm: vmscan: fix typo in isolating lru pages

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



(12/29/11 7:38 AM), Hillf Danton wrote:
It is not the tag page but the cursor page that we should process, and it looks
a typo.

Signed-off-by: Hillf Danton<dhillf@xxxxxxxxx>
Cc: Michal Hocko<mhocko@xxxxxxx>
Cc: KAMEZAWA Hiroyuki<kamezawa.hiroyu@xxxxxxxxxxxxxx>
Cc: Andrew Morton<akpm@xxxxxxxxxxxxxxxxxxxx>
Cc: David Rientjes<rientjes@xxxxxxxxxx>
Cc: Hugh Dickins<hughd@xxxxxxxxxx>
---

--- a/mm/vmscan.c	Thu Dec 29 20:20:16 2011
+++ b/mm/vmscan.c	Thu Dec 29 20:23:30 2011
@@ -1231,13 +1231,13 @@ static unsigned long isolate_lru_pages(u

  				mem_cgroup_lru_del(cursor_page);
  				list_move(&cursor_page->lru, dst);
-				isolated_pages = hpage_nr_pages(page);
+				isolated_pages = hpage_nr_pages(cursor_page);
  				nr_taken += isolated_pages;
  				nr_lumpy_taken += isolated_pages;
  				if (PageDirty(cursor_page))
  					nr_lumpy_dirty += isolated_pages;
  				scan++;
-				pfn += isolated_pages-1;
+				pfn += isolated_pages - 1;
  			} else {
  				/*
  				 * Check if the page is freed already.

Looks correct.

Acked-by: KOSAKI Motohiro <kosaki.motohiro@xxxxxxxxxxxxxx>


--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxx.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>


[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]