> +{ > + if (!cma) > + return; Do we really need that check for NULL? > + > + cma->reserve_pages_on_error = true; > +} > + > /** > * cma_init_reserved_mem() - create custom contiguous area from reserved memory > * @base: Base address of the reserved area > @@ -204,6 +214,7 @@ int __init cma_init_reserved_mem(phys_addr_t base, phys_addr_t size, > cma->base_pfn = PFN_DOWN(base); > cma->count = size >> PAGE_SHIFT; > cma->order_per_bit = order_per_bit; > + cma->reserve_pages_on_error = false; I think you can drop that; should already be initialized to 0. Apart from that Reviewed-by: David Hildenbrand <david@xxxxxxxxxx> -- Thanks, David / dhildenb