On Tue 27-12-11 21:38:59, Hillf Danton wrote: > On Tue, Dec 27, 2011 at 9:30 PM, Michal Hocko <mhocko@xxxxxxx> wrote: > > On Tue 27-12-11 21:21:18, Hillf Danton wrote: > >> On Tue, Dec 27, 2011 at 8:59 PM, Michal Hocko <mhocko@xxxxxxx> wrote: > >> > On Fri 23-12-11 21:41:08, Hillf Danton wrote: > >> >> From: Hillf Danton <dhillf@xxxxxxxxx> > >> >> Subject: [PATCH] mm: hugetlb: add might_sleep() for gigantic page > >> >> > >> >> Like the case of huge page, might_sleep() is added for gigantic page, then > >> >> both are treated in same way. > >> > > >> > Why do we need to call might_sleep here? There is cond_resched in the > >> > loop... > >> > > >> > >> IIUC it is the reason to add... and the comment says > > > > cond_resched calls __might_sleep so there is no reason to call > > might_sleep outside the loop as well. > > > Yes, thanks. And remove it in the huge page case? Yes, makes sense. -- Michal Hocko SUSE Labs SUSE LINUX s.r.o. Lihovarska 1060/12 190 00 Praha 9 Czech Republic -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>