On Mon, Jan 10, 2022 at 12:41:22AM -0800, Christoph Hellwig wrote:
> On Mon, Jan 10, 2022 at 04:24:04AM +0000, Matthew Wilcox (Oracle) wrote:
> > +static inline struct folio *gup_folio_range_next(unsigned long i,
> > unsigned long npages, struct page *start, unsigned int *ntails)
> > {
> > - struct page *next, *page;
> > + struct page *next;
> > + struct folio *folio;
> > unsigned int nr = 1;
> >
> > next = nth_page(start, i);
> > + folio = page_folio(next);
>
> Superficial nit: initialization next and folio at declaration time
> would reada little better.
Done. Also the previous patch:
-static inline struct page *compound_next(struct page **list,
+static inline struct folio *gup_folio_next(struct page **list,
unsigned long npages, unsigned long i, unsigned int *ntails)
{
- struct page *page;
+ struct folio *folio = page_folio(list[i]);
unsigned int nr;
- page = compound_head(list[i]);
for (nr = i + 1; nr < npages; nr++) {
