On Fri 23-12-11 21:35:25, Hillf Danton wrote:
> From: Hillf Danton <dhillf@xxxxxxxxx>
> Subject: [PATCH] mm: hugetlb: fix non-atomic enqueue of huge page
>
> If huge page is enqueued under the protection of hugetlb_lock, then
> the operation is atomic and safe.
>
> Cc: Michal Hocko <mhocko@xxxxxxx>
> Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@xxxxxxxxxxxxxx>
> Cc: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
> Signed-off-by: Hillf Danton <dhillf@xxxxxxxxx>
Yes, looks correct even though the changelog could be more verbose.
The code is broken since .37
Reviewed-by: Michal Hocko <mhocko@xxxxxxx>
Thanks
> ---
>
> --- a/mm/hugetlb.c Tue Dec 20 21:26:30 2011
> +++ b/mm/hugetlb.c Fri Dec 23 21:16:28 2011
> @@ -901,7 +901,6 @@ retry:
> h->resv_huge_pages += delta;
> ret = 0;
>
> - spin_unlock(&hugetlb_lock);
> /* Free the needed pages to the hugetlb pool */
> list_for_each_entry_safe(page, tmp, &surplus_list, lru) {
> if ((--needed) < 0)
> @@ -915,6 +914,7 @@ retry:
> VM_BUG_ON(page_count(page));
> enqueue_huge_page(h, page);
> }
> + spin_unlock(&hugetlb_lock);
>
> /* Free unnecessary surplus pages to the buddy allocator */
> free:
--
Michal Hocko
SUSE Labs
SUSE LINUX s.r.o.
Lihovarska 1060/12
190 00 Praha 9
Czech Republic
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxx. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>