Re: [PATCH v2 05/28] gup: Change the calling convention for compound_next()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: "Matthew Wilcox (Oracle)" <willy@xxxxxxxxxxxxx>
Subject: Re: [PATCH v2 05/28] gup: Change the calling convention for compound_next()
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Mon, 10 Jan 2022 00:27:29 -0800
Cc: linux-mm@xxxxxxxxx, John Hubbard <jhubbard@xxxxxxxxxx>, Christoph Hellwig <hch@xxxxxxxxxxxxx>, William Kucharski <william.kucharski@xxxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, Jason Gunthorpe <jgg@xxxxxxxx>
In-reply-to: <20220110042406.499429-6-willy@infradead.org>
References: <20220110042406.499429-1-willy@infradead.org> <20220110042406.499429-6-willy@infradead.org>

On Mon, Jan 10, 2022 at 04:23:43AM +0000, Matthew Wilcox (Oracle) wrote:
> Return the head page instead of storing it to a passed parameter.

Looks good, but same comment about maybe passing list and npages first.

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

Follow-Ups:
- Re: [PATCH v2 05/28] gup: Change the calling convention for compound_next()
  - From: Matthew Wilcox

References:
- [PATCH v2 00/28] Convert GUP to folios
  - From: Matthew Wilcox (Oracle)
- [PATCH v2 05/28] gup: Change the calling convention for compound_next()
  - From: Matthew Wilcox (Oracle)

Prev by Date: Re: [PATCH v2 04/28] gup: Optimise compound_range_next()
Next by Date: Re: [PATCH v2 06/28] gup: Fix some contiguous memmap assumptions
Previous by thread: [PATCH v2 05/28] gup: Change the calling convention for compound_next()
Next by thread: Re: [PATCH v2 05/28] gup: Change the calling convention for compound_next()
Index(es):
- Date
- Thread

[Index of Archives] [Linux ARM Kernel] [Linux ARM] [Linux Omap] [Fedora ARM] [IETF Annouce] [Bugtraq] [Linux OMAP] [Linux MIPS] [eCos] [Asterisk Internet PBX] [Linux API]

Powered by Linux