Hi Hongchen, Thank you for the patch! Yet something to improve: [auto build test ERROR on linux/master] [also build test ERROR on linus/master hnaz-mm/master v5.16-rc8 next-20220106] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Hongchen-Zhang/signal-strict-valid-signal-check/20220107-124756 base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 136057256686de39cc3a07c2e39ef6bc43003ff6 config: hexagon-randconfig-r041-20220107 (https://download.01.org/0day-ci/archive/20220107/202201072220.gCthUkw6-lkp@xxxxxxxxx/config) compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 32167bfe64a4c5dd4eb3f7a58e24f4cba76f5ac2) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/d6ab2033eb509bf064e07f58074e58562098dfcc git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Hongchen-Zhang/signal-strict-valid-signal-check/20220107-124756 git checkout d6ab2033eb509bf064e07f58074e58562098dfcc # save the config file to linux build tree mkdir build_dir COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=hexagon SHELL=/bin/bash drivers/tty/ If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@xxxxxxxxx> All errors (new ones prefixed by >>): In file included from drivers/tty/tty_io.c:71: >> include/linux/signal.h:277:16: error: implicit declaration of function 'min' [-Werror,-Wimplicit-function-declaration] return sig <= min(_NSIG, 127) ? 1 : 0; ^ 1 error generated. vim +/min +277 include/linux/signal.h 269 270 /* Test if 'sig' is valid signal. Use this instead of testing _NSIG directly */ 271 static inline int valid_signal(unsigned long sig) 272 { 273 /* max usable signal number is limited by both _NSIG and task's 274 * exit_code, and the max available signal number encoded in 275 * task's exit_code is 127. 276 */ > 277 return sig <= min(_NSIG, 127) ? 1 : 0; 278 } 279 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx
