Hi SeongJae,
On 1/6/2022 7:40 PM, SeongJae Park wrote:
Hi Baolin,
Thank you always for your great contribution! As always, trivial comments
below.
On Thu, 6 Jan 2022 18:40:11 +0800 Baolin Wang <baolin.wang@xxxxxxxxxxxxxxxxx> wrote:
It will never get a NULL page by pte_page(), thus remove the redundant
page validation to fix below Smatch static checker warning.
I guess the issue has reported in the open place[1], right? I think it would
be better to add the link in this commit message, so that future readers can
read and learn from your discussion in the mail thread.
[1] https://lore.kernel.org/linux-mm/20220106091200.GA14564@kili/
OK.
mm/damon/vaddr.c:405 damon_hugetlb_mkold()
warn: 'page' can't be NULL.
Sorry for continuously obsessing about this trivial and personal taste, but...
Could you please indent quoting blocks like above (hopefully with 4 spaces)?
That makes the message much easier to read for me, and I'd like to keep the
commit messages for DAMON consistent and easy to read, at least for me.
Sure, I will keep the rule of DAMON in mind.
Andrew, could you help to change the commit message format as SeongJae
suggested when you apply this patch? Thanks.
Other than that,
Reviewed-by: SeongJae Park <sj@xxxxxxxxxx>
Thanks.
