On Wed, Jan 05, 2022 at 12:44:38AM -0800, John Hubbard wrote: > On 1/2/22 13:57, Matthew Wilcox (Oracle) wrote: > > +int isolate_lru_page(struct page *page) > > +{ > > + if (WARN_RATELIMIT(PageTail(page), "trying to isolate tail page")) > > + return -EBUSY; > > + return isolate_lru_folio((struct folio *)page); > > This cast is not great to have, but it is correct, given the above > constraints about tail pages...and I expect this sort of thing is > temporary, anyway? We could call page_folio() here, but we already know the answer. The whole of folio-compat.c is temporary. Any time I have the luxury of boredom, grepping for any of the functions in folio-compat will show something that needs to be converted to use folios.