On Sun, 2 Jan 2022, Christoph Hellwig wrote: > On Sun, Jan 02, 2022 at 05:32:28PM -0800, Hugh Dickins wrote: > > > > + same_folio = (lstart >> PAGE_SHIFT) == (lend >> PAGE_SHIFT); > > Should this move to the else branch? We could add an else branch and move it there, yes. I liked Matthew's else-less style with partial_end, and followed that. Whatever: since he posted that diff yesterday, I imagine he'll just merge this into the fixed patch, in whatever style he prefers. > > Same for the other copy of this code. Otherwise this looks sane. Thanks, Hugh
